Validating Phone number

[lenz1979]

Hi!

i use Sugar CE 6.2.3 and wanted to change the phone Validation.

in sugar_grp1.js a function isValidPhone exists but it seems that the type phone will not call this function.

in the editview:

addToValidate('EditView', 'phone_fax', 'phone', false,'Fax' );

but it seems to ignore the type "phone".

is this a bug or is there no real phone validation?

adding the following code in the switch will help calling the isValidPhone:

break;case'phone':if(!isValidPhone(trim(form[validate[formname][i][nameIndex]].value))){isError=true;add_error_style(formname,va lidate[formname][i][nameIndex],invalidTxt+" "+validate[formname][i][msgIndex]);}

[rafael.q.g@hotmail.com]

I have two suggestions you could try:
1. Add on extensions for your module some code like: $dictionary['module_name']['fields']['field_name']['required']=true;
2. Write a logic hook to validate field's content.

[anthony.watson]

Which logic hook would you use? I don't know of any that trigger before submit (but before_submit would be a good name for it). The closest hook to that is before_save, and by that point, the UI is already being reloaded.

Same goes for the controller.

The only solution that comes to my mind is to write your own event listener script, include it via editviewdefs, and basically fake the validation by checking the contents (maybe on blur?) and if it returns false, fire whatever the validator would fire for false. Let me check....

if(!isValidPhone(document.getElementById("phone_home").value )) {
    isError = true;
    add_error_style("EditView", "phone_home", invalidTxt + " " + "Home Phone");
}

Let me know if that works. I only tested it from the javascript console, so I don't know if it will actually prevent the form from submitting, etc.

[rafael.q.g@hotmail.com]

The logic hook you need is: "before_save".

[anthony.watson]

Before save is not the place to put a validator, I don't think, as the form is already submitted. You can't prevent the save from competing (without killing the entire thread).

[Angel]

Agreed, a logic hook is not the place for this as it doesn't have a way to interact with the interface so as to alert the user that they've done something they shouldn't do or that the data is bad, etc.

There are a couple of ways of applying validation, but if you want it to occur when the Save button is clicked, take a look at this thread, as it has a good example of what to do:

Problem with Javascript on Save Button custom code